You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### Rationale for this change
#44249
### What changes are included in this PR?
Change all the system header inclusions to `simd.h`.
Also removed some duplicated defines.
### Are these changes tested?
Existing tests should be good.
### Are there any user-facing changes?
None.
* GitHub Issue: #44249
Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Describe the enhancement requested
Some of simd-related files are including concrete system headers such as:
arrow/cpp/src/arrow/acero/bloom_filter.h
Lines 20 to 22 in 6f64af5
However I see that https://github.com/apache/arrow/blob/6f64af54ea3662b7e1685b84a81429df14beace1/cpp/src/arrow/util/simd.h seems to be a centralized header to sort out all the platform-specific checks. Besides, I think it is a good place to put universal definitions - e.g. working around certain compiler bugs like what #44116 did - to be visible to all simd source files.
Therefore I think we can unify the simd header inclusion by utilizing
simd.h
.Component(s)
C++
The text was updated successfully, but these errors were encountered: