-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44111: [CI][Python] Enable S3 tests on macOS CI #44129
Conversation
|
b2deec8
to
7a75b3a
Compare
@github-actions crossbow submit wheel-macos* |
Revision: dfc79d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-575374bf24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No `minio` command cannot be located
in test logs.
@github-actions crossbow submit wheel-macos* |
Revision: a4b52d7 Submitted crossbow builds: ursacomputing/crossbow @ actions-0dd60e1229 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3600db8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
S3 support is enabled when building PyArrow for macOS (both on PR builds and in Crossbow wheel builds), but minio wan't installed before testing, therefore S3 support in PyArrow was not tested at all.
What changes are included in this PR?
Ensure Minio is installed before running PyArrow tests on macOS builds.
Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.