[C++][Gandiva] Attribute mismatch error with unity build

[kou]

Describe the bug, including details regarding any error messages, version, and platform.

[678/708] Building CXX object src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx.o
FAILED: src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx.o 
/opt/homebrew/bin/ccache /Library/Developer/CommandLineTools/usr/bin/c++ -DARROW_EXTRA_ERROR_CONTEXT -DARROW_HAVE_NEON -DARROW_STATIC -DARROW_WITH_TIMING_TESTS -DGANDIVA_STATIC -DGANDIVA_UNIT_TEST=1 -I/Users/kou/work/cpp/arrow/cpp.build/src -I/Users/kou/work/cpp/arrow/cpp/src -I/Users/kou/work/cpp/arrow/cpp/src/generated -isystem /Users/kou/work/cpp/arrow/cpp/thirdparty/flatbuffers/include -isystem /Users/kou/work/cpp/arrow/cpp.build/_deps/googletest-src/googletest/include -isystem /Users/kou/work/cpp/arrow/cpp.build/_deps/googletest-src/googletest -isystem /Users/kou/work/cpp/arrow/cpp.build/_deps/googletest-src/googlemock/include -isystem /Users/kou/work/cpp/arrow/cpp.build/_deps/googletest-src/googlemock -isystem /opt/homebrew/include -fno-aligned-new  -Qunused-arguments -fcolor-diagnostics  -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -g -Werror -O0 -ggdb  -std=c++17 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk -fPIE -MD -MT src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx.o -MF src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx.o.d -o src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx.o -c /Users/kou/work/cpp/arrow/cpp.build/src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx
In file included from /Users/kou/work/cpp/arrow/cpp.build/src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx:7:
In file included from /Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/bitmap_test.cc:19:
In file included from /Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/types.h:22:
/Users/kou/work/cpp/arrow/cpp/src/gandiva/gdv_function_stubs.h:77:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
GANDIVA_EXPORT
^
/Users/kou/work/cpp/arrow/cpp/src/gandiva/visibility.h:39:39: note: expanded from macro 'GANDIVA_EXPORT'
#define GANDIVA_EXPORT __attribute__((visibility("default")))
                                      ^
/Users/kou/work/cpp/arrow/cpp/src/gandiva/context_helper.cc:63:6: note: previous definition is here
void gdv_fn_context_set_error_msg(int64_t context_ptr, char const* err_msg) {
     ^
In file included from /Users/kou/work/cpp/arrow/cpp.build/src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx:7:
In file included from /Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/bitmap_test.cc:19:
In file included from /Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/types.h:22:
/Users/kou/work/cpp/arrow/cpp/src/gandiva/gdv_function_stubs.h:80:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
GANDIVA_EXPORT
^
/Users/kou/work/cpp/arrow/cpp/src/gandiva/visibility.h:39:39: note: expanded from macro 'GANDIVA_EXPORT'
#define GANDIVA_EXPORT __attribute__((visibility("default")))
                                      ^
/Users/kou/work/cpp/arrow/cpp/src/gandiva/context_helper.cc:68:10: note: previous definition is here
uint8_t* gdv_fn_context_arena_malloc(int64_t context_ptr, int32_t size) {
         ^
2 errors generated.

src/gandiva/precompiled/CMakeFiles/gandiva-precompiled-test.dir/Unity/unity_0_cxx.cxx:

/* generated by CMake */

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/context_helper.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/bitmap_test.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/bitmap.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/epoch_time_point_test.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/time_test.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/time.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/precompiled/timestamp_arithmetic.cc"

/* NOLINTNEXTLINE(bugprone-suspicious-include,misc-include-cleaner) */
#include "/Users/kou/work/cpp/arrow/cpp/src/gandiva/cast_time.cc"

Component(s)

C++ - Gandiva

[kou]

Issue resolved by pull request 43464
#43464