[Python] Mappings that implement __arrow_c_schema__ never have their method invoked
#43388
Comments
ianmcook
changed the title
__arrow_c_schema__ never have their method invoked__arrow_c_schema__ never have their method invoked
|
Good point, thanks for the issue! |
jorisvandenbossche
added a commit
to jorisvandenbossche/arrow
that referenced
this issue
Jul 30, 2024
|
-> #43486 |
jorisvandenbossche
added a commit
that referenced
this issue
Aug 7, 2024
…a(..) (#43486) ### Rationale for this change When converting an object to a pyarrow.Schema with `pa.schema(..)`, first check the capsule interface before checking for mappings. This allows other schema-like objects that expose the capsule interface to also be mappings. ### Are these changes tested? Yes * GitHub Issue: #43388 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
Issue resolved by pull request 43486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
The implementation of
pyarrow.schemadoesn't allow objects that areMappings to take advantage of__arrow_c_schema__becauseMappingis checked before__arrow_c_schema__is checked.This seems like a bug considering that custom schema objects naturally fit into the
Mappingconcept.Would it make sense to swap the order here and first check for
__arrow_c_schema__and then check whether an object is a mapping?Component(s)
Python
The text was updated successfully, but these errors were encountered: