Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][Parquet] Documentation to parquet.write_table should be updated for new byte_stream_split encoding options #41748

Closed
etseidl opened this issue May 21, 2024 · 2 comments

Comments

@etseidl
Copy link
Contributor

etseidl commented May 21, 2024

Describe the enhancement requested

The docstring for parquet.write_table still says BYTE_STREAM_SPLIT encoding is valid only for floating-point data. This should be updated now that other fixed length types are supported.

Component(s)

Parquet, Python

@ianmcook
Copy link
Member

cc @pitrou

pitrou added a commit to pitrou/arrow that referenced this issue May 21, 2024
jorisvandenbossche pushed a commit that referenced this issue May 22, 2024
…rite_table() docstring (#41759)

### Rationale for this change

In PR #40094 (issue GH-39978), we forgot to update the `write_table` docstring with an accurate description of the supported data types for BYTE_STREAM_SPLIT.

### Are these changes tested?

No (only a doc change).

### Are there any user-facing changes?

No.
* GitHub Issue: #41748

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 41759
#41759

@jorisvandenbossche jorisvandenbossche added this to the 17.0.0 milestone May 22, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…n in write_table() docstring (apache#41759)

### Rationale for this change

In PR apache#40094 (issue apacheGH-39978), we forgot to update the `write_table` docstring with an accurate description of the supported data types for BYTE_STREAM_SPLIT.

### Are these changes tested?

No (only a doc change).

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41748

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants