Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Local CompressedInputArguments function is flagged as unused by the compiler #40983

Closed
felipecrv opened this issue Apr 3, 2024 · 1 comment
Closed

[C++] Local CompressedInputArguments function is flagged as unused by the compiler #40983

felipecrv opened this issue Apr 3, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

CompressedInputArguments is, depending on build flags, defined and not used. When building with -Werror, the build fails.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Apr 3, 2024
Merged
mapleFU pushed a commit that referenced this issue Apr 3, 2024
@felipecrv
GH-40983: [C++] Fix unused function build error (#40984)
8c09c7f 
### Rationale for this change

Make sure local `CompressedInputArguments` is only defined when it's being used.

### What changes are included in this PR?

Wrapping definition and usage under the same `#ifdef`.

### Are these changes tested?

By building with `-Werror` and running all existing tests.
* GitHub Issue: #40983

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@mapleFU mapleFU added this to the 16.0.0 milestone Apr 3, 2024
@mapleFU
Copy link
Member

mapleFU commented Apr 3, 2024

Issue resolved by pull request 40984
#40984

@mapleFU mapleFU closed this as completed Apr 3, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@felipecrv @tolleybot
apacheGH-40983: [C++] Fix unused function build error (apache#40984)
e19af17 
### Rationale for this change

Make sure local `CompressedInputArguments` is only defined when it's being used.

### What changes are included in this PR?

Wrapping definition and usage under the same `#ifdef`.

### Are these changes tested?

By building with `-Werror` and running all existing tests.
* GitHub Issue: apache#40983

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@felipecrv @vibhatha
apacheGH-40983: [C++] Fix unused function build error (apache#40984)
16d94de 
### Rationale for this change

Make sure local `CompressedInputArguments` is only defined when it's being used.

### What changes are included in this PR?

Wrapping definition and usage under the same `#ifdef`.

### Are these changes tested?

By building with `-Werror` and running all existing tests.
* GitHub Issue: apache#40983

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@felipecrv @mapleFU