[GLib] Add missing compute function options classes #40402
Comments
kou
added a commit
that referenced
this issue
Mar 8, 2024
### Rationale for this change In most cases the options to compute functions are optional, but there are cases where they are required. The following compute functions are not possible to use in Ruby because the required options classes are missing from the GLib bindings: * `split_pattern` * `strftime` (can technically be used) * `strptime` * `struct_field` There are probably more functions that cannot be used, but this is a start. ### What changes are included in this PR? The following GLib classes are added: * `GArrowSplitPatternOptions` * `GArrowStrftimeOptions` * `GArrowStrptimeOptions` * `GArrowStructFieldOptions` To be able to return an error, a separate function for setting the field_ref on StructFieldOptions is used instead of a set_property function. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * GitHub Issue: #40402 Lead-authored-by: Sten Larsson <sten@burtcorp.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
Issue resolved by pull request 40403 |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…pache#40403) ### Rationale for this change In most cases the options to compute functions are optional, but there are cases where they are required. The following compute functions are not possible to use in Ruby because the required options classes are missing from the GLib bindings: * `split_pattern` * `strftime` (can technically be used) * `strptime` * `struct_field` There are probably more functions that cannot be used, but this is a start. ### What changes are included in this PR? The following GLib classes are added: * `GArrowSplitPatternOptions` * `GArrowStrftimeOptions` * `GArrowStrptimeOptions` * `GArrowStructFieldOptions` To be able to return an error, a separate function for setting the field_ref on StructFieldOptions is used instead of a set_property function. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * GitHub Issue: apache#40402 Lead-authored-by: Sten Larsson <sten@burtcorp.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
In most cases the options to compute functions are optional, but there are cases where they are required. The following compute functions are not possible to use in Ruby because the required options classes are missing from the GLib bindings:
split_pattern:SplitPatternOptionsstrftime:StrftimeOptions(technically not required)strptime:StrptimeOptionsstruct_field:StructFieldOptionsThere are probably more functions that cannot be used, but this is a start.
Component(s)
GLib
The text was updated successfully, but these errors were encountered: