-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R]: Bundle dependency source so that we can build from source on CRAN even when offline #39859
Comments
jonkeane
added a commit
that referenced
this issue
Feb 1, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: #39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
assignUser
pushed a commit
that referenced
this issue
Feb 8, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: #39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: apache#39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: apache#39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
thisisnic
pushed a commit
that referenced
this issue
Mar 1, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: #39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
thisisnic
pushed a commit
that referenced
this issue
Mar 8, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: #39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: apache#39859 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
We have been asked to only build from source on CRAN and to include all sources necessary so that we can build offline.
This is a partial step to partially deal with #39806
Component(s)
R
The text was updated successfully, but these errors were encountered: