Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Environment credential authentication #39345

Closed
Tom-Newton opened this issue Dec 21, 2023 · 4 comments
Closed

[C++][FS][Azure] Environment credential authentication #39345

Tom-Newton opened this issue Dec 21, 2023 · 4 comments
Assignees
@Tom-Newton
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Child of #38598

Environment credential is the same as client secret except it extracts the important values from standard environment variables instead of just arguments in the code.

https://github.com/Azure/azure-sdk-for-cpp/blob/main/sdk/identity/azure-identity/src/environment_credential.cpp

Component(s)

C++
@Tom-Newton Tom-Newton mentioned this issue Dec 21, 2023
Open
1 task
@kou kou mentioned this issue Dec 22, 2023
Closed
@felipecrv
Copy link
Contributor

Note: even though there isn't a way to explicitly configure AzureOptions to get credentials from the environment, the AzureOptions::ConfigureDefaultCredential() will cause the Azure SDK to probe the environment for credentials and build the appropriate auth token.

@kou
Copy link
Member

kou commented Jan 9, 2024

It means that we don't need to implement this feature because we already implemented the feature as AzureOptions::ConfigureDefaultCredential(), right?

@Tom-Newton
Copy link
Contributor Author

Tom-Newton commented Jan 9, 2024 •
edited
Loading

I think ideally we should implement this. The default credential is often useful but it doesn't give you control in a case where your environment has Auth configured in more than one way. Also it tends to fail very slowly if you have no Auth configured.

@github-actions github-actions bot mentioned this issue May 18, 2024
Merged
kou pushed a commit that referenced this issue Jun 3, 2024
@Tom-Newton
GH-39345: [C++][FS][Azure] Add support for environment credential (#4…
02585cd 
…1715)

### Rationale for this change
Maybe be useful to support explicit environment credential (currently environment credential can be used as part of the Azure default credential flow). 

### What changes are included in this PR?

### Are these changes tested?
There are new unittests but no integration tests that we can actually authenticate successfully. We are relying on the Azure C++ SDK to abstracting that away. 

### Are there any user-facing changes?
Yes, environment credential is now available. 

* GitHub Issue: #39345

Authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 17.0.0 milestone Jun 3, 2024
@kou
Copy link
Member

kou commented Jun 3, 2024

Issue resolved by pull request 41715
#41715

@kou kou closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@kou @felipecrv @Tom-Newton