Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Integration] Add support for C abi Utf8View to the go implementation #39013

Closed
bkietz opened this issue Nov 30, 2023 · 0 comments · Fixed by #39019
Closed

[Go][Integration] Add support for C abi Utf8View to the go implementation #39013

bkietz opened this issue Nov 30, 2023 · 0 comments · Fixed by #39019
Assignees
@bkietz
Labels
Component: Go Component: Integration Type: enhancement
Milestone
15.0.0

Comments

@bkietz
Copy link
Member

bkietz commented Nov 30, 2023

Describe the enhancement requested

After #35769 , we can add support for importing/exporting arrays through the C abi and test between C++ and go

Component(s)

Go, Integration
@bkietz bkietz self-assigned this Nov 30, 2023
bkietz added a commit to bkietz/arrow that referenced this issue Dec 1, 2023
@bkietz
apacheGH-39013: [Go][Integration] Support cABI import/export of Strin…
7de4b26 
…gView in Go
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Merged
bkietz added a commit to bkietz/arrow that referenced this issue Dec 12, 2023
@bkietz
apacheGH-39013: [Go][Integration] Support cABI import/export of Strin…
56f7134 
…gView in Go
zeroshade added a commit that referenced this issue Dec 19, 2023
@bkietz @zeroshade @felipecrv
GH-39013: [Go][Integration] Support cABI import/export of StringView (#…
3e182f2 
…39019)

### Rationale for this change

The Go implementation should support import/export of the new data types. This will enable integration testing between the C++ and Go implementations.

### What changes are included in this PR?

Added import/export for the new data types and arrays of data of those types.

### Are these changes tested?

Yes, they will be covered by the integration tests and existing Go unit tests.

### Are there any user-facing changes?

This is a user facing change

* Closes: #39013

Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 15.0.0 milestone Dec 19, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@bkietz @zeroshade
@felipecrv @clayburn
apacheGH-39013: [Go][Integration] Support cABI import/export of Strin…
030dca9 
…gView (apache#39019)

### Rationale for this change

The Go implementation should support import/export of the new data types. This will enable integration testing between the C++ and Go implementations.

### What changes are included in this PR?

Added import/export for the new data types and arrays of data of those types.

### Are these changes tested?

Yes, they will be covered by the integration tests and existing Go unit tests.

### Are there any user-facing changes?

This is a user facing change

* Closes: apache#39013

Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@bkietz @zeroshade
@felipecrv @dgreiss
apacheGH-39013: [Go][Integration] Support cABI import/export of Strin…
7bfbfea 
…gView (apache#39019)

### Rationale for this change

The Go implementation should support import/export of the new data types. This will enable integration testing between the C++ and Go implementations.

### What changes are included in this PR?

Added import/export for the new data types and arrays of data of those types.

### Are these changes tested?

Yes, they will be covered by the integration tests and existing Go unit tests.

### Are there any user-facing changes?

This is a user facing change

* Closes: apache#39013

Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkietz bkietz

Labels
Component: Go Component: Integration Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39013: [Go][Integration] Support cABI import/export of StringView bkietz/arrow
2 participants
@zeroshade @bkietz