Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlightSQL] Provide mock server #37795

Closed
jduo opened this issue Sep 19, 2023 · 1 comment · Fixed by #37837
Closed

[Java][FlightSQL] Provide mock server #37795

jduo opened this issue Sep 19, 2023 · 1 comment · Fixed by #37837
Assignees
@jduo
Labels
Component: FlightRPC Component: Java Type: enhancement
Milestone
14.0.0

Comments

@jduo
Copy link
Member

jduo commented Sep 19, 2023

Describe the enhancement requested

Create a mock Flight SQL server similar to what's available for Flight to allow developers working on Flight producers to easily test their code.

Write some simple tests using this server for issuing getFlightInfo() requests for various commands and getting streams back.

Component(s)

FlightRPC, Java
@jduo
Copy link
Member Author

jduo commented Sep 19, 2023

take

jduo added a commit to jduo/arrow that referenced this issue Sep 22, 2023
@jduo
apacheGH-37795: Add mock FlightSqlProducer and tests
c120394 
Add helper classes for creating a No-op Flight SQL producer and a partially implemented
FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial
implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.
@github-actions github-actions bot mentioned this issue Sep 22, 2023
Merged
lidavidm pushed a commit that referenced this issue Sep 25, 2023
@jduo
GH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (#37837
3c013da 
)

### Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

### What changes are included in this PR?

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 14.0.0 milestone Sep 25, 2023
etseidl pushed a commit to etseidl/arrow that referenced this issue Sep 28, 2023
@jduo @etseidl
apacheGH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (
bac589c 
apache#37837)

### Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

### What changes are included in this PR?

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@jduo
apacheGH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (
364acd3 
apache#37837)

### Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

### What changes are included in this PR?

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@jduo @loicalleyne
apacheGH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (
35940fc 
apache#37837)

### Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

### What changes are included in this PR?

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
stevelorddremio pushed a commit to stevelorddremio/arrow that referenced this issue Jan 19, 2024
@jduo @stevelorddremio
apacheGH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (
803a679 
apache#37837)

Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

Yes.

No.
* Closes: apache#37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests (
034dbe4 
apache#37837)

### Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.

### What changes are included in this PR?

Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.

Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.

Clean-up missed closes of FlightStreams in TestFlightSql.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37795

Authored-by: James Duong <duong.james@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: FlightRPC Component: Java Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests jduo/arrow
2 participants
@lidavidm @jduo