Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Parquet] Implement Float16 logical type #37582

Closed
benibus opened this issue Sep 6, 2023 · 0 comments · Fixed by #37599
Closed

[Go][Parquet] Implement Float16 logical type #37582

benibus opened this issue Sep 6, 2023 · 0 comments · Fixed by #37599
Assignees
@benibus
Labels
Component: Go Component: Parquet Type: enhancement
Milestone
15.0.0

Comments

@benibus
Copy link
Collaborator

benibus commented Sep 6, 2023

Describe the enhancement requested

As a follow-up to #36036, we should add an equivalent implementation for Go as well.

Component(s)

Go, Parquet
@github-actions github-actions bot mentioned this issue Sep 6, 2023
Merged
3 tasks
zeroshade pushed a commit that referenced this issue Nov 13, 2023
@benibus
GH-37582: [Go][Parquet] Implement Float16 logical type (#37599)
bff5fb9 
### Rationale for this change

There is an active proposal for a Float16 logical type in Parquet (apache/parquet-format#184) with C++/Python implementations in progress (#36073), so we should add one for Go as well.

### What changes are included in this PR?

- [x] Adds `LogicalType` definitions and methods for `Float16`
- [x] Adds support for `Float16` column statistics and comparators
- [x] Adds support for interchange between Parquet and Arrow's half-precision float

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes

* Closes: #37582

Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 15.0.0 milestone Nov 13, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@benibus @loicalleyne
apacheGH-37582: [Go][Parquet] Implement Float16 logical type (apache#…
171606a 
…37599)

### Rationale for this change

There is an active proposal for a Float16 logical type in Parquet (apache/parquet-format#184) with C++/Python implementations in progress (apache#36073), so we should add one for Go as well.

### What changes are included in this PR?

- [x] Adds `LogicalType` definitions and methods for `Float16`
- [x] Adds support for `Float16` column statistics and comparators
- [x] Adds support for interchange between Parquet and Arrow's half-precision float

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes

* Closes: apache#37582

Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This was referenced Jan 25, 2024
Closed
Closed
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@benibus @dgreiss
apacheGH-37582: [Go][Parquet] Implement Float16 logical type (apache#…
e355d72 
…37599)

### Rationale for this change

There is an active proposal for a Float16 logical type in Parquet (apache/parquet-format#184) with C++/Python implementations in progress (apache#36073), so we should add one for Go as well.

### What changes are included in this PR?

- [x] Adds `LogicalType` definitions and methods for `Float16`
- [x] Adds support for `Float16` column statistics and comparators
- [x] Adds support for interchange between Parquet and Arrow's half-precision float

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes

* Closes: apache#37582

Authored-by: benibus <bpharks@gmx.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibus benibus

Labels
Component: Go Component: Parquet Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-37582: [Go][Parquet] Implement Float16 logical type benibus/arrow
2 participants
@zeroshade @benibus