Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] conda-forge sets build type in CMAKE_ARGS #37266

Closed
pitrou opened this issue Aug 21, 2023 · 1 comment · Fixed by #37272
Closed

[C++] conda-forge sets build type in CMAKE_ARGS #37266

pitrou opened this issue Aug 21, 2023 · 1 comment · Fixed by #37272
Assignees
@pitrou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 21, 2023

Describe the bug, including details regarding any error messages, version, and platform.

As a result of conda-forge/ctng-compiler-activation-feedstock#94, conda-forge has started putting CMAKE_BUILD_TYPE in CMAKE_ARGS.

This is breaking CI builds for us:
https://github.com/apache/arrow/actions/runs/5904814214/job/16017685263?pr=37174

Component(s)

C++
@pitrou
Copy link
Member Author

pitrou commented Aug 21, 2023

@kou

pitrou added a commit to pitrou/arrow that referenced this issue Aug 21, 2023
@pitrou
apacheGH-37266: [CI][C++] Avoid clobbering build type with CMAKE_ARGS
f883af5 
Since CMAKE_ARGS could in some circumstances (conda-forge) override CMAKE_BUILD_TYPE, pass it first and let our own choice override it.
@github-actions github-actions bot mentioned this issue Aug 21, 2023
Closed
@github-actions github-actions bot mentioned this issue Aug 21, 2023
Merged
pitrou added a commit that referenced this issue Aug 22, 2023
@pitrou
GH-37266: [CI][C++] Use ARROW_CMAKE_ARGS not CMAKE_ARGS (#37272)
9ddd8d5 
* Closes: #32766
* Closes: #37266

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 22, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pitrou @loicalleyne
apacheGH-37266: [CI][C++] Use ARROW_CMAKE_ARGS not CMAKE_ARGS (apache…
da4751a 
…#37272)

* Closes: apache#32766
* Closes: apache#37266

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
14.0.0
1 participant
@pitrou