[C++][CI] DecimalToReal test failure on 32-bit x86 Debian #36767
Comments
|
cc @js8544 |
pitrou
added a commit
to pitrou/arrow
that referenced
this issue
Jul 19, 2023
Storing the computation result in a local variable (as part of a change to improve error messages) fixes the failure observed on CI. This is probably due to x86 FPU rounding shenanigans, as explained here: https://stackoverflow.com/questions/37626687/c-fundamentals-double-variable-not-equal-to-double-expression
pitrou
added a commit
that referenced
this issue
Jul 19, 2023
### Rationale for this change Our nightly build on i386 Debian (a 32-bit x86 build) fails with an error in decimal-to-read tests: https://github.com/ursacomputing/crossbow/actions/runs/5593823296/jobs/10227952675#step:6:3255 ### What changes are included in this PR? Improve error messages by displaying the actual and expected values. A side effect of this error message improvement is to... fix the test failure, as storing the computation result in a local variable seems to change the computed absolute difference. This is probably due to x86 FPU rounding shenanigans, as explained here: https://stackoverflow.com/questions/37626687/c-fundamentals-double-variable-not-equal-to-double-expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #36767 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this issue
Jul 20, 2023
### Rationale for this change Our nightly build on i386 Debian (a 32-bit x86 build) fails with an error in decimal-to-read tests: https://github.com/ursacomputing/crossbow/actions/runs/5593823296/jobs/10227952675#step:6:3255 ### What changes are included in this PR? Improve error messages by displaying the actual and expected values. A side effect of this error message improvement is to... fix the test failure, as storing the computation result in a local variable seems to change the computed absolute difference. This is probably due to x86 FPU rounding shenanigans, as explained here: https://stackoverflow.com/questions/37626687/c-fundamentals-double-variable-not-equal-to-double-expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36767 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
### Rationale for this change Our nightly build on i386 Debian (a 32-bit x86 build) fails with an error in decimal-to-read tests: https://github.com/ursacomputing/crossbow/actions/runs/5593823296/jobs/10227952675#step:6:3255 ### What changes are included in this PR? Improve error messages by displaying the actual and expected values. A side effect of this error message improvement is to... fix the test failure, as storing the computation result in a local variable seems to change the computed absolute difference. This is probably due to x86 FPU rounding shenanigans, as explained here: https://stackoverflow.com/questions/37626687/c-fundamentals-double-variable-not-equal-to-double-expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36767 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
See nightly build here:
https://github.com/ursacomputing/crossbow/actions/runs/5593823296/jobs/10227952675#step:6:3255
This can be reproducer locally using:
Component(s)
C++
The text was updated successfully, but these errors were encountered: