Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Expose keys_sorted in MapType #35112

Closed
0x26res opened this issue Apr 13, 2023 · 0 comments · Fixed by #35113
Closed

[python] Expose keys_sorted in MapType #35112

0x26res opened this issue Apr 13, 2023 · 0 comments · Fixed by #35113
Assignees
@0x26res
Labels
Component: Python Type: enhancement
Milestone
13.0.0

Comments

@0x26res
Copy link
Contributor

0x26res commented Apr 13, 2023

Describe the enhancement requested

That field is present in the C++ representation of MapType but not accessible in the python API.

I think it's just a matter of adding it to the types.pxi.

Component(s)

Python
@github-actions github-actions bot mentioned this issue Apr 13, 2023
Merged
0x26res pushed a commit to 0x26res/arrow that referenced this issue Apr 18, 2023
Merge remote-tracking branch 'origin/master' into apacheGH-35112-pyth…
f65f7f3 
…on-expose-keys-sorted-in-map-type
AlenkaF pushed a commit that referenced this issue Apr 18, 2023
@0x26res
GH-35112: [Python] Expose keys_sorted in python MapType (#35113)
1deb740 
### Rationale for this change

It not possible to read `keys_sorted` in the python API

### What changes are included in this PR?

- expose keys_sorted in `cdef class MapType` / types.pxi
- add tests

### Are these changes tested?

yes

### Are there any user-facing changes?

We're exposing keys_sorted but I guess the documentation will update itself from the `"""` pydoc (?)

This is not an API breaking change

* Closes: #35112

Authored-by: aandres <aandres@tradewelltech.co>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
@AlenkaF AlenkaF added this to the 13.0.0 milestone Apr 18, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@0x26res @liujiacheng777
apacheGH-35112: [Python] Expose keys_sorted in python MapType (apache…
1fcdd1e 
…#35113)

### Rationale for this change

It not possible to read `keys_sorted` in the python API

### What changes are included in this PR?

- expose keys_sorted in `cdef class MapType` / types.pxi
- add tests

### Are these changes tested?

yes

### Are there any user-facing changes?

We're exposing keys_sorted but I guess the documentation will update itself from the `"""` pydoc (?)

This is not an API breaking change

* Closes: apache#35112

Authored-by: aandres <aandres@tradewelltech.co>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@0x26res @ArgusLi
apacheGH-35112: [Python] Expose keys_sorted in python MapType (apache…
c2cd38d 
…#35113)

### Rationale for this change

It not possible to read `keys_sorted` in the python API

### What changes are included in this PR?

- expose keys_sorted in `cdef class MapType` / types.pxi
- add tests

### Are these changes tested?

yes

### Are there any user-facing changes?

We're exposing keys_sorted but I guess the documentation will update itself from the `"""` pydoc (?)

This is not an API breaking change

* Closes: apache#35112

Authored-by: aandres <aandres@tradewelltech.co>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@0x26res @rtpsw
apacheGH-35112: [Python] Expose keys_sorted in python MapType (apache…
1bf3eac 
…#35113)

### Rationale for this change

It not possible to read `keys_sorted` in the python API

### What changes are included in this PR?

- expose keys_sorted in `cdef class MapType` / types.pxi
- add tests

### Are these changes tested?

yes

### Are there any user-facing changes?

We're exposing keys_sorted but I guess the documentation will update itself from the `"""` pydoc (?)

This is not an API breaking change

* Closes: apache#35112

Authored-by: aandres <aandres@tradewelltech.co>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x26res 0x26res

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35112: [Python] Expose keys_sorted in python MapType 0x26res/arrow
2 participants
@0x26res @AlenkaF