[Java] When loading NullVector, valueCount should be properly set #34610
Comments
pitrou
pushed a commit
that referenced
this issue
Nov 29, 2023
…ing NullVector (#38973) ### Rationale for this change This is a follow up of #34611 (thanks @ sunchao) We should set `valueCount` when loading `NullVector`. Unfortunately there's no `nullCount` field. ### What changes are included in this PR? * `valueCount` added to NullVector * `name` added to NullVector's TransferPair ### Are these changes tested? Yes. unit tested. ### Are there any user-facing changes? Yes, a NullVector with a non-null name will maintain the name when transferred via `TransferPair` instead of defaulting to the default name `$data$`. * Closes: #34610 Authored-by: Chao Sun <sunchao@apple.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…nsferring NullVector (apache#38973) ### Rationale for this change This is a follow up of apache#34611 (thanks @ sunchao) We should set `valueCount` when loading `NullVector`. Unfortunately there's no `nullCount` field. ### What changes are included in this PR? * `valueCount` added to NullVector * `name` added to NullVector's TransferPair ### Are these changes tested? Yes. unit tested. ### Are there any user-facing changes? Yes, a NullVector with a non-null name will maintain the name when transferred via `TransferPair` instead of defaulting to the default name `$data$`. * Closes: apache#34610 Authored-by: Chao Sun <sunchao@apple.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
In
NullVector.loadFieldBufferswe currently don't setvalueCount, which is incorrect.Component(s)
Java
The text was updated successfully, but these errors were encountered: