Skip to content

Commit

Permalink
[JS]: Remove skip js test and update ci test
Browse files Browse the repository at this point in the history
  • Loading branch information
handstuyennn committed Sep 4, 2024
1 parent 1143877 commit ded7890
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions dev/archery/archery/integration/datagen.py
Original file line number Diff line number Diff line change
Expand Up @@ -1887,11 +1887,9 @@ def _temp_path():

generate_duration_case(),

generate_interval_case()
.skip_tester('JS'), # TODO(ARROW-5239): Intervals + JS
generate_interval_case(),

generate_month_day_nano_interval_case()
.skip_tester('JS'),
generate_month_day_nano_interval_case(),

generate_map_case(),

Expand Down
2 changes: 1 addition & 1 deletion js/test/unit/vector/interval-month-day-nano-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function formatIntervalValue(value: IntervalValue): IntervalValue {
function convertIntervalValueToIntArray(value: IntervalValue): Int32Array {
const int64s = new BigInt64Array(2);
int64s[0] = BigInt(value.months ?? 0) + BigInt(value.days ?? 0) * (BigInt(1) << BigInt(32));
int64s[1] = value.nanoseconds ? value.nanoseconds : BigInt(0);
int64s[1] = value.nanoseconds ?? BigInt(0);
return new Int32Array(int64s.buffer);
}

Expand Down

0 comments on commit ded7890

Please sign in to comment.