Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parquet module documentation to reflect correct SerializedFileReader location #909

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

kingeasternsun
Copy link
Contributor

Which issue does this PR close?

Closes #908

Rationale for this change

What changes are included in this PR?

fix the document link of parquet::file

Are there any user-facing changes?

no

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 3, 2021
@alamb alamb added the documentation Improvements or additions to documentation label Nov 3, 2021
@alamb alamb changed the title Update mod.rs Update parquet module documentation to reflect correct SerializedFileReader location Nov 3, 2021
@alamb
Copy link
Contributor

alamb commented Nov 3, 2021

Thanks @kingeasternsun !

@alamb
Copy link
Contributor

alamb commented Nov 3, 2021

MIRI failure is also unrelated.

@alamb alamb merged commit 67af0d0 into apache:master Nov 3, 2021
alamb pushed a commit that referenced this pull request Nov 4, 2021
alamb added a commit that referenced this pull request Nov 5, 2021
Co-authored-by: kingeasternsun <kingeasternsun@gmail.com>
@kingeasternsun
Copy link
Contributor Author

Thanks @kingeasternsun !

my pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the SerializedFileReader has moved from reader to serialized_reader , but document of mod.rs not updated
3 participants