Cherry pick fix: bug in offset calculation for unions to active_release #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `value_offset` function only read the least significant byte in the offset array, causing issues with unions with more than 255 rows of any given variant. Fix the issue by reading the entire i32 offset and add a unit test.
Codecov Report
@@ Coverage Diff @@
## active_release #871 +/- ##
==================================================
+ Coverage 82.47% 82.48% +0.01%
==================================================
Files 168 168
Lines 48083 48108 +25
==================================================
+ Hits 39658 39684 +26
+ Misses 8425 8424 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of 05eb63f