Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case which shows empty list of struct cannot be written #704

Closed
wants to merge 1 commit into from

Conversation

mosyp
Copy link
Contributor

@mosyp mosyp commented Aug 20, 2021

Which issue does this PR close?

Shows the simple repro steps for #703

What changes are included in this PR?

Just a test case

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 20, 2021
@alamb
Copy link
Contributor

alamb commented Aug 20, 2021

I wonder if #692 could be related. It is also in parquet and affects a similar sounding part of the codebase

@nevi-me
Copy link
Contributor

nevi-me commented Sep 1, 2021

I wonder if #692 could be related. It is also in parquet and affects a similar sounding part of the codebase

It's unrelated @alamb. The bug is with how levels of <list<struct<_>> are calculated.

@mosyp I'll pick this PR up for the test case when I submit a PR that fixes the underlying issue.

@nevi-me
Copy link
Contributor

nevi-me commented Sep 14, 2021

I have a potential fix for this, where this test case no longer fails, but I'm still verifying the outputs and fixing the regressions with other tests. I'll put something up soon as I'm done @mosyp @xianwill

@alamb
Copy link
Contributor

alamb commented Dec 20, 2021

Marking PRs that are over a month old as stale -- please let us know if there is additional work planned or if we should close them.

@alamb
Copy link
Contributor

alamb commented Jan 19, 2022

I merged this branch to master and with the fix from #1166 from @helgikrs this test now passes 🎉

warning: `parquet` (test "array_struct_bug") generated 8 warnings
    Finished test [unoptimized + debuginfo] target(s) in 9.62s
     Running tests/array_struct_bug.rs (/Users/alamb/Software/df-target/debug/deps/array_struct_bug-ffc075f6b2fe1ef0)

running 1 test
test array_struct_bug ... ok

Thanks again for the report @mosyp

@alamb alamb closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants