Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate #6976

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate #6976

merged 2 commits into from
Jan 21, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 13, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

Since NullBuffer is not re-exported in arrow it is hard to find downstream

What changes are included in this PR?

  1. Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate
  2. Add some doc examples

Are there any user-facing changes?

NullBufferBuilder can be used from the arrow rate. For example:

Screenshot 2025-01-13 at 3 47 01 PM

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 13, 2025
Jefffrey
Jefffrey approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2025

Thank you for the review @Jefffrey

@alamb alamb merged commit 4b38ff5 into apache:main Jan 21, 2025
26 checks passed
@alamb alamb deleted the alamb/export_null_buffer-builder branch January 21, 2025 11:25
@alamb alamb mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-export NullBufferBuilder in the arrow crate
2 participants
@alamb @Jefffrey