Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error rather than panic when too many row groups are written #6629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return error rather than panic when too many row groups are written #6629

wants to merge 2 commits into from

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 25, 2024

Which issue does this PR close?

Closes #6591.

Rationale for this change

Does not panic in the unlikely event that the row group ordinal is negative when writing bloom filters.

What changes are included in this PR?

Replace expect with map_err, also adds test for changes from #6378.

Are there any user-facing changes?

No, since the panic should no longer be possible to trigger.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 25, 2024
@etseidl
Copy link
Contributor Author

etseidl commented Oct 25, 2024

I wrote the test trying to track down #6591...if we don't want it then this can just be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Instead of Panic On Attempting to Write More Than 32769 Row Groups
1 participant
@etseidl