Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow-json writer empty #6614

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix arrow-json writer empty #6614

merged 1 commit into from
Oct 23, 2024

Conversation

gwik
Copy link
Contributor

@gwik gwik commented Oct 22, 2024

The Writer output with the ArrayJson formatter was empty when no record were in the output (no write or empty batch write). It should output an empty JSON array [] instead.

Closes #6613

The Writer output with the ArrayJson formatter was empty
when no record were in the output (no write or empty batch write).
It should output an empty JSON array `[]` instead.
@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 22, 2024
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding new tests!

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit f86668c into apache:master Oct 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array writer output empty when no record is written
3 participants