Add ParquetObjectReader::with_runtime
#6612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
tustvold
reviewed
Oct 21, 2024
| #[tokio::test] | ||
| // We need to mark this with the `target_has_atomic` because the spawned_tasks_count() fn is | ||
| // only available for that cfg | ||
| #[cfg(all(target_has_atomic = "64", tokio_unstable))] |
There was a problem hiding this comment.
I wonder if we could instead create a runtime with IO / blocking threads disabled and use that to determine that the IO was spawned to a different runtime?
There was a problem hiding this comment.
I don't think that would work. I'm not certain why, but ParquetObjectReader seems to work fine regardless of whether or not IO is 'enabled' on its runtime. I was able to change the tests so they don't rely on tokio_unstable anymore and (I think) still show what we want them to show, so I'll push that in a minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6248
What changes are included in this PR?
This PR works on top of #6249 to add a test for the new
with_runtimefn, as well as changing the signature of thespawnfunction slightly to avoid an extra re-boxing when a runtime is set.This also fixes a few things that
clippywas complaining about.Rationale for this change
See #6248 for the API addition.
With regard to the test, I felt like this is really the only test we'd want for this feature - we just want to make sure that the runtime is actually being used by
ParquetObjectReader. We can't make any guarantees about how it actually performs or would work if there's another runtime being used for CPU-bound operations, so all we really want to test is if it is used.Are there any user-facing changes?
No