Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building FixedSizeListBuilder in struct_builder's mak… #6595

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Add support for building FixedSizeListBuilder in struct_builder's mak… #6595

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be56f11
Add support for building FixedSizeListBuilder in struct_builder's mak…
kszlim Oct 20, 2024
b9539e2
Fix formatting
kszlim Oct 20, 2024
e2995d5
Merge branch 'apache:master' into patch-1
kszlim Oct 21, 2024
b03161a
Make suggested fixes + add test
kszlim Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions arrow-array/src/builder/struct_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,13 @@ pub fn make_builder(datatype: &DataType, capacity: usize) -> Box<dyn ArrayBuilde
let builder = make_builder(field.data_type(), capacity);
Box::new(LargeListBuilder::with_capacity(builder, capacity).with_field(field.clone()))
}
DataType::FixedSizeList(field, size) => {
let builder = make_builder(field.data_type(), capacity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be capacity*size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm are you sure, @tustvold I followed the pattern for the above Listbuilder, seems like either that's wrong too or this is right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ListBuilder doesn't have a fixed size

Box::new(
FixedSizeListBuilder::with_capacity(builder, *size, capacity)
.with_field(field.clone()),
)
}
DataType::Map(field, _) => match field.data_type() {
DataType::Struct(fields) => {
let map_field_names = MapFieldNames {
Expand Down
Loading