chore: Make binary_mut kernel accept different type for second arg #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Jun 2, 2024
|
This is technically an API change as it could effect type inference |
|
Thank you @tustvold |
alamb
reviewed
Jun 3, 2024
| @@ -224,14 +224,15 @@ where | |||
| /// This function gives error if the arrays have different lengths. | |||
| /// This function gives error of original [`PrimitiveArray`] `a` if it is not a mutable | |||
| /// primitive array. | |||
| pub fn binary_mut<T, F>( | |||
| pub fn binary_mut<T, U, F>( | |||
There was a problem hiding this comment.
FWIW I have added a doc example (and thus test coverage) for this change in #5798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5818.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?