Update docs for datatypes #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Dec 30, 2023
| @@ -23,14 +23,18 @@ use crate::{Field, FieldRef, Fields, UnionFields}; | |||
| /// The set of datatypes that are supported by this implementation of Apache Arrow. | |||
| /// | |||
| /// The Arrow specification on data types includes some more types. | |||
| /// See also [`Schema.fbs`](https://github.com/apache/arrow/blob/master/format/Schema.fbs) | |||
| /// See also [`Schema.fbs`](https://github.com/apache/arrow/blob/main/format/Schema.fbs) | |||
There was a problem hiding this comment.
Current link works but shows popup everytime:
So just change to main
arrow-schema/src/datatype.rs
Outdated
Comment on lines
154
to
158
| /// Must be either seconds or millieseconds. | ||
| Time32(TimeUnit), | ||
| /// A 64-bit time representing the elapsed time since midnight in the unit of `TimeUnit`. | ||
| /// Must be either microseconds or nanoseconds. | ||
| Time64(TimeUnit), |
There was a problem hiding this comment.
Want to be explicit here as in isolation it can imply Time64 could take on seconds/milliseconds and Time32 could take on microseconds/nanoseconds based on TimeUnit enum alone
7 tasks
alamb
approved these changes
Dec 31, 2023
| /// for Arrow's specification. | ||
| /// | ||
| /// The variants of this enum include primitive fixed size types as well as parametric or | ||
| /// nested types. | ||
| /// Currently the Rust implementation supports the following nested types: | ||
| /// Currently the Rust implementation supports the following nested types: |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
tustvold
approved these changes
Dec 31, 2023
viirya
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Update docs for datatypes
What changes are included in this PR?
Are there any user-facing changes?