Add IPC FileDecoder #5249
Merged
Add IPC FileDecoder #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Dec 27, 2023
Comment on lines
+575
to
+598
| /// let trailer_start = buffer.len() - 10; | ||
| /// let footer_len = read_footer_length(buffer[trailer_start..].try_into().unwrap()).unwrap(); | ||
| /// let footer = root_as_footer(&buffer[trailer_start - footer_len..trailer_start]).unwrap(); | ||
| /// | ||
| /// let back = fb_to_schema(footer.schema().unwrap()); | ||
| /// assert_eq!(&back, schema.as_ref()); | ||
| /// | ||
| /// let mut decoder = FileDecoder::new(schema, footer.version()); | ||
| /// | ||
| /// // Read dictionaries | ||
| /// for block in footer.dictionaries().iter().flatten() { | ||
| /// let block_len = block.bodyLength() as usize + block.metaDataLength() as usize; | ||
| /// let data = buffer.slice_with_length(block.offset() as _, block_len); | ||
| /// decoder.read_dictionary(&block, &data).unwrap(); | ||
| /// } | ||
| /// | ||
| /// // Read record batch | ||
| /// let batches = footer.recordBatches().unwrap(); | ||
| /// assert_eq!(batches.len(), 1); // Only wrote a single batch | ||
| /// | ||
| /// let block = batches.get(0); | ||
| /// let block_len = block.bodyLength() as usize + block.metaDataLength() as usize; | ||
| /// let data = buffer.slice_with_length(block.offset() as _, block_len); | ||
| /// let back = decoder.read_record_batch(block, &data).unwrap().unwrap(); |
There was a problem hiding this comment.
This is still somewhat verbose, but I couldn't see an easy way to reduce this further that didn't end up in knots with self-referential structs (as flatbuffers borrow data)
tustvold
commented
Dec 27, 2023
| pub fn read_record_batch( | ||
| &self, | ||
| block: &Block, | ||
| buf: &Buffer, |
There was a problem hiding this comment.
It is perhaps worth noting that this interface won't allow pushing down column projection to IO, I think this is a bridge we cross when we add support for this.
This was referenced Dec 28, 2023
7 tasks
viirya
reviewed
Dec 29, 2023
|
|
||
| /// Read the dictionary with the given block and data buffer | ||
| pub fn read_dictionary(&mut self, block: &Block, buf: &Buffer) -> Result<(), ArrowError> { | ||
| let message = self.read_message(buf)?; |
There was a problem hiding this comment.
Not bit deal but seems we didn't check for metadata version for DictionaryBatch before. Maybe it was missed before.
viirya
approved these changes
Dec 30, 2023
viirya
reviewed
Dec 30, 2023
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
😆 -- love it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5153
Closes #5165
Closes #5252
Part of #1207
Rationale for this change
In a similar vein to arrow-csv and arrow-json this extracts a low-level, push-based interface for decoding files. This lends itself to use-cases that need more control over how IO is performed, for example:
What changes are included in this PR?
Are there any user-facing changes?