Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme instructions to reflect new structure #524

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

marcvanheerden
Copy link
Contributor

Which issue does this PR close?

Closes #523 .

Rationale for this change

The readme was out of date

What changes are included in this PR?

update code snippets in readme developer instructions section

Are there any user-facing changes?

No

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marcvanheerden !

@codecov-commenter
Copy link

Codecov Report

Merging #524 (42668a7) into master (21d69ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 42668a7 differs from pull request most recent head 3015f55. Consider uploading reports for the commit 3015f55 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         167      167           
  Lines       45956    45956           
=======================================
  Hits        37933    37933           
  Misses       8023     8023           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d69ca...3015f55. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jul 6, 2021

https://github.com/apache/arrow-rs/pull/524/checks?check_run_id=3001616900 is unrelated to this PR (I think @ritchie46 fixed it in #525); Merging in

@alamb alamb merged commit a1aace8 into apache:master Jul 6, 2021
@alamb alamb added the documentation Improvements or additions to documentation label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README developer instructions out of date
3 participants