Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Correct array memory usage calculation for dictionary arrays to active_release #515

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 30, 2021

Automatic cherry-pick of f1a831f

* Correct array memory usage calculation for dictionary arrays

* update comments

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* update comments

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Adjust memory usage calculation and move related tests to the same file

* Comment about bitmap size

* Clippy fixes

* Adjust calculation for validity bitmap

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #515 (9d2e599) into active_release (32b835e) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #515      +/-   ##
==================================================
+ Coverage           82.68%   82.79%   +0.10%     
==================================================
  Files                 163      163              
  Lines               44957    44940      -17     
==================================================
+ Hits                37172    37206      +34     
+ Misses               7785     7734      -51     
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 92.23% <ø> (+2.10%) ⬆️
arrow/src/array/array_boolean.rs 94.01% <ø> (+3.10%) ⬆️
arrow/src/array/array_dictionary.rs 88.48% <ø> (+3.60%) ⬆️
arrow/src/array/array_list.rs 94.88% <ø> (+2.06%) ⬆️
arrow/src/array/array_primitive.rs 94.60% <ø> (-0.10%) ⬇️
arrow/src/array/array_string.rs 97.76% <ø> (+1.71%) ⬆️
arrow/src/array/array_struct.rs 89.24% <ø> (+1.39%) ⬆️
arrow/src/array/array_union.rs 89.26% <ø> (+2.33%) ⬆️
arrow/src/array/null.rs 83.78% <ø> (-2.89%) ⬇️
arrow/src/array/array.rs 80.90% <100.00%> (+4.04%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b835e...9d2e599. Read the comment docs.

@alamb alamb merged commit c053601 into active_release Jul 1, 2021
@alamb alamb deleted the cherry_pick_f1a831fe branch July 14, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants