Support onelake fabric paths in parse_url (#5000) #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmuddassir-msft can you please help review this PR? |
crepererum
approved these changes
Nov 2, 2023
Thanks for adding Fabric paths . this should solve the issue with generic parse_url error:feature for http not enabled when used with deltalake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5000
Rationale for this change
#4573 added support for parsing these URLs within
MicrosoftAzureBuilder, this PR extends theObjectStoreSchemedetection logic to also understand these paths, so thatparse_urlhandles them correctlyWhat changes are included in this PR?
Are there any user-facing changes?