Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flatbuffers #499

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Bump flatbuffers #499

merged 1 commit into from
Jun 24, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jun 23, 2021

Signed-off-by: Chojan Shang psiace@outlook.com

Which issue does this PR close?

Closes #476

Reference rustsec/advisory-db#917 and Wait rustsec/advisory-db#943

Rationale for this change

On the one hand, we should pay attention to security issues. On the other hand, the new version may be better.

What changes are included in this PR?

Just bump flatbuffers and add unsafe mark .

Are there any user-facing changes?

No user-facing changes.

Signed-off-by: Chojan Shang <psiace@outlook.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #499 (4defd62) into master (9723209) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         165      165           
  Lines       45664    45664           
=======================================
+ Hits        37728    37729    +1     
+ Misses       7936     7935    -1     
Impacted Files Coverage Δ
arrow/src/ipc/gen/SparseTensor.rs 0.00% <0.00%> (ø)
arrow/src/ipc/gen/Message.rs 34.40% <33.33%> (ø)
arrow/src/ipc/gen/Schema.rs 41.05% <65.00%> (ø)
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9723209...4defd62. Read the comment docs.

@alamb alamb added api-change Changes to the arrow API and removed api-change Changes to the arrow API labels Jun 24, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PsiACE

@jorgecarleitao jorgecarleitao merged commit 7bea1f6 into apache:master Jun 24, 2021
alamb pushed a commit that referenced this pull request Jun 24, 2021
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE PsiACE deleted the bump-flatbuffers branch June 24, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
5 participants