Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine documentation to
Array::is_null
#4838Refine documentation to
Array::is_null
#4838Changes from 4 commits
78b885a
65b0b16
6613635
39bf205
6ad27ab
983aca6
fcc108b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've said this before but I think from a user PoV, having
is_null
andis_logical_null
is confusing as hell. Which NULL isis_null
?! Yeah, historically this is the physical null but do most users really care about the physical repr.? I would argue that at least this method should be calledis_physical_null
to force users to think about what kind of null they want, instead of tricking them into using the wrong implicit default for their use case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting that is_null should always return logical nullability? What about for RunArray where this would have
O(log(n))
complexity? What about null_count? The only consistent thing I can see is to only ever return physical nullability...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that
is_null
should be renamed tois_physical_null
(potentially w/ a soft deprecation period) to avoid that users accidentally pick the wrong method.You make a good point regarding
null_count
. My argument would be: rename that one as well, tophysical_null_count
. Then it's clear to which semantic you're referring to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #4840 to track