Minor: improve docs and add example for lexicographical_partition_ranges #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Aug 1, 2023
tustvold
reviewed
Aug 2, 2023
Comment on lines
+32
to
+34
| /// Returns an iterator with `k` items where `k` is cardinality of the | ||
| /// sort values: Consecutive values will be connected: `(a, b)` and `(b, | ||
| /// c)`, where `start = 0` and `end = n` for the first and last range. |
There was a problem hiding this comment.
Suggested change
| /// Returns an iterator with `k` items where `k` is cardinality of the | |
| /// sort values: Consecutive values will be connected: `(a, b)` and `(b, | |
| /// c)`, where `start = 0` and `end = n` for the first and last range. | |
| /// Returns an iterator with `k` items where `k` is cardinality of the | |
| /// sort values. Consecutive ranges will be contiguous: `(a, b)` and `(b, | |
| /// c)`, where `start = 0` and `end = n` for the first and last range. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #4575
Rationale for this change
While reviewing #4575 I wanted to make sure I really understood what was going on, so I made some pictures
What changes are included in this PR?
Add docstrings with ASCII art diagram and code example
Are there any user-facing changes?
docs