Consolidate sort benchmarks #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jul 31, 2023
|
|
||
| c.bench_function("sort nulls 2^10", |b| { | ||
| b.iter(|| bench_sort(&arr_a, &arr_b, None)) | ||
| let arr = create_f32_array(2_usize.pow(12), false); |
There was a problem hiding this comment.
We previously had very limited coverage of sort_to_indices, despite this being one of the more important sort functions
crepererum
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I found the existing benchmarks somewhat confusing as it wasn't immediately clear what variant they were testing. This matters as lexsort, sort_to_indices and sort, all have differing implementations
What changes are included in this PR?
Are there any user-facing changes?