Mark GenericByteArray::new_unchecked unsafe #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
approved these changes
Jul 30, 2023
findepi
reviewed
Sep 2, 2024
| @@ -159,7 +159,7 @@ impl<T: ByteArrayType> GenericByteArray<T> { | |||
| /// # Safety | |||
| /// | |||
| /// Safe if [`Self::try_new`] would not error | |||
| pub fn new_unchecked( | |||
| pub unsafe fn new_unchecked( | |||
There was a problem hiding this comment.
Can you please elaborate more on the why we need unsafe here?
cc @Xuanwo
There was a problem hiding this comment.
See the checks done by try_new, in particular that the offsets are valid, and the data is UTF-8 (if applicable)
There was a problem hiding this comment.
thanks @tustvold . so this allows creating an array without validation, thus with potentially invalid data. is this also unsafe in rust unsafe sense (potential program undefined behavior)?
There was a problem hiding this comment.
Yes, very much so. Many kernels and methods make assumptions about data validity that would lead to UB if not upheld.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?