-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support NullArray un arith/boolean kernel #4566
Conversation
arrow-arith/src/boolean.rs
Outdated
None => BooleanBuffer::new_unset(input.len()), | ||
// NullArray has no nulls buffer yet all values are null | ||
None => { | ||
if input.data_type().equals_datatype(&DataType::Null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or should we check for input to be NullArray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments
arrow-arith/src/boolean.rs
Outdated
None => BooleanBuffer::new_set(input.len()), | ||
None => { | ||
// NullArray has no nulls buffer yet all values are null | ||
if input.data_type().equals_datatype(&DataType::Null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if input.data_type().equals_datatype(&DataType::Null) { | |
if input.data_type() == &DataType::Null { |
Could also possibly be lifted into the match expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done (both)
f4455e6
to
77c94db
Compare
Thank you |
* support NullArray un arith/boolean kernel * prettify based on feedback
* support NullArray un arith/boolean kernel * prettify based on feedback
Which issue does this PR close?
Closes #4565.
Rationale for this change
What changes are included in this PR?
Since NullArray has no nulls buffer, we need to handle that case for
is_null
andis_not_null
to work correctlyAre there any user-facing changes?
Nope
Don't think so
Nope