Implement the Iterator trait for the json Reader. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 12, 2021
There was a problem hiding this comment.
Thank you for the contribution @LaurentMazare ! This looks like a great improvement to me.
arrow/src/json/reader.rs
Outdated
| type Item = Result<RecordBatch>; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| match self.next() { |
There was a problem hiding this comment.
I think you might be able to do self.next().transpose() here
There was a problem hiding this comment.
Ah indeed that sounds more idiomatic, I just pushed this change.
alamb
approved these changes
Jun 12, 2021
| type Item = Result<RecordBatch>; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| self.next().transpose() |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 82.65% 82.66%
=======================================
Files 164 164
Lines 45468 45481 +13
=======================================
+ Hits 37581 37596 +15
+ Misses 7887 7885 -2
Continue to review full report at Codecov.
|
nevi-me
approved these changes
Jun 13, 2021
alamb
pushed a commit
that referenced
this pull request
Jun 22, 2021
* Implement the Iterator trait for the json Reader. * Use transpose.
|
This is planned for release in arrow-rs 4.4.0 FYI |
alamb
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #193 (JSON reader does not implement iterator).
Rationale for this change
Fairly straightforward change that makes it easy to iterate over
RecordBatchwhen reading a json file.What changes are included in this PR?
Iteratortrait directly onjson::Reader.Are there any user-facing changes?
None expected, this adds a
nextfunction as part of the trait, there is already a publicnextfunction defined onjson::Readerand this doesn't seem to be an issue.