Remove DictionaryArray::keys_array method #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorstmann
commented
Jun 6, 2021
| @@ -1450,7 +1451,8 @@ where | |||
| cast_with_options(&dict_array.values(), to_type, cast_options)?; | |||
|
|
|||
| // Note take requires first casting the indices to u32 | |||
| let keys_array: ArrayRef = Arc::new(dict_array.keys_array()); | |||
| let keys_array: ArrayRef = | |||
There was a problem hiding this comment.
If primitive arrays were cloneable this would just be Arc::new(dict_array.keys().clone()).
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 82.62% 82.62% -0.01%
==========================================
Files 162 162
Lines 44479 44469 -10
==========================================
- Hits 36750 36741 -9
+ Misses 7729 7728 -1
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 7, 2021
|
@andygrove @Dandandan @jorgecarleitao @paddyhoran @tustvold @nevi-me any thoughts on this proposal? |
jorgecarleitao
approved these changes
Jun 8, 2021
Dandandan
approved these changes
Jun 9, 2021
|
I'll wait a few more days before merging this in to see if there is any more feedback. As this is not compatible, I won't backport to the 4.x line |
alamb
added
api-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #391.
Rationale for this change
The
keys_arraycan be a performance problem if used in inner loops and most usages can be directly replaced by thekeysmethod which returns a reference without any cloning or allocations.What changes are included in this PR?
Removed the method and replaced it's usages with the
keysmethod.Are there any user-facing changes?
Yes, this is a breaking change.
This is currently a draft because there were actually two usages in the
castkernels that could not be directly replaced. We do not seem to have an obvious way to get from&PrimitiveArray<T>toArrayRef. This transformation would be much easier if thePrimitiveArrayitself was cloneable.