feat: support async writer (#1269) #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tustvold PTAL |
tustvold
approved these changes
Mar 27, 2023
|
The ci is broken, I will fix them. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1269.
Rationale for this change
Currently, async api for arrow writer has not been supported yet. And if the underlying storage's api is async, it is difficult to use the arrow writer api, and a workaround way is to collect all the bytes in memory and then feed them to the underlying storage by the async api, which may lead to high memory consumption if the final parquet file is large.
So we need an async api for the arrow writer, allowing that the caller can integrate an async underlying storage easily, e.g object store.
What changes are included in this PR?
buffer_flush_thresholdto allow the caller can control the memory usage.Are there any user-facing changes?
Async api for Arrow writer:
AsyncArrowWriter.