Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing timestamps of exactly 32 characters #3902

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Mar 22, 2023

Which issue does this PR close?

related to #3801

Rationale for this change

Parsing 2018-11-13T17:11:10.011375885995 would panic with an out of range error

Found by apache/datafusion#5685

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 22, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 Thank you @tustvold

@tustvold tustvold merged commit 8ac54d3 into apache:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants