Array equality for &dyn Array (#3880) #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 21, 2023
| @@ -425,13 +425,13 @@ pub trait ArrayAccessor: Array { | |||
| unsafe fn value_unchecked(&self, index: usize) -> Self::Item; | |||
| } | |||
|
|
|||
| impl PartialEq for dyn Array { | |||
| impl PartialEq for dyn Array + '_ { | |||
There was a problem hiding this comment.
This is the major "fix", previously this had an implicit 'static lifetime for dyn Array, which would then result in incredibly opaque compilation errors if you actually tried to use this
There was a problem hiding this comment.
I don't even understand what this means -- "any lifeime"?
There was a problem hiding this comment.
It's documented here - https://doc.rust-lang.org/reference/lifetime-elision.html#default-trait-object-lifetimes
I was aware it applied to things like Box<dyn Foo> but hadn't occurred to me that dyn Foo on its own also has an implicit 'static
tustvold
force-pushed
the
array-equality-dyn-array
branch
from
8e60645
to
9d618fa
Compare
alamb
approved these changes
Mar 22, 2023
| @@ -425,13 +425,13 @@ pub trait ArrayAccessor: Array { | |||
| unsafe fn value_unchecked(&self, index: usize) -> Self::Item; | |||
| } | |||
|
|
|||
| impl PartialEq for dyn Array { | |||
| impl PartialEq for dyn Array + '_ { | |||
There was a problem hiding this comment.
I don't even understand what this means -- "any lifeime"?
| let b = NullArray::new(12); | ||
| let b = b.data(); | ||
| test_equal(a, b, true); | ||
| test_equal(&a, &b, true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3880
Rationale for this change
This is part of being able to move away from
Array::dataWhat changes are included in this PR?
Are there any user-facing changes?