Add BooleanArray::new (#3879) #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
add-boolean-array-new
branch
from
65c28c5
to
7cf2ebd
Compare
jhorstmann
reviewed
Mar 22, 2023
| let data = unsafe { | ||
| ArrayData::builder(DataType::Boolean) | ||
| .len(values.len()) | ||
| .offset(values.offset()) |
There was a problem hiding this comment.
Not directly related to the BooleanArray, but do we now allow different offsets for values and null buffers and do compute kernels handle this correctly?
There was a problem hiding this comment.
Yes, this change landed in #3778
alamb
approved these changes
Mar 22, 2023
viirya
reviewed
Mar 22, 2023
arrow-buffer/src/buffer/boolean.rs
Outdated
| @@ -60,6 +62,12 @@ impl BooleanBuffer { | |||
| } | |||
| } | |||
|
|
|||
| /// Invokes `f` with values `0..len` collecting the boolean results into a new `BooleanBuffer` | |||
There was a problem hiding this comment.
Suggested change
| /// Invokes `f` with values `0..len` collecting the boolean results into a new `BooleanBuffer` | |
| /// Invokes `f` with indexes `0..len` collecting the boolean results into a new `BooleanBuffer` |
viirya
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Rationale for this change
Adds a safe API for constructing a BooleanArray from its constituent parts.
I have confirmed this has no impact on benchmarks
What changes are included in this PR?
Are there any user-facing changes?