Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for FlightSQL CLI client #3816

Merged
merged 2 commits into from
Mar 9, 2023
Merged

test: add test for FlightSQL CLI client #3816

merged 2 commits into from
Mar 9, 2023

Conversation

crepererum
Copy link
Contributor

Which issue does this PR close?

Closes #3814.

Rationale for this change

Let's have some rough tests before adding more features.

What changes are included in this PR?

  • Tiny test w/ a dummy server.
  • Fix for non-HTTPS connections.

Are there any user-facing changes?

Using the CLI w/ non-HTTPS connections now works.

@crepererum crepererum marked this pull request as ready for review March 7, 2023 15:11
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Mar 7, 2023
alamb
alamb approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crepererum

I ran the test locally like

 cargo test --features=cli,tls,flight-sql-experimental --test flight_sql_client_cli

I also double checked that this test runs as part of CI(as it has several required features ) and it does ✅

https://github.com/apache/arrow-rs/actions/runs/4355722022/jobs/7612726842#step:6:141

cc @avantgardnerio

arrow-flight/tests/flight_sql_client_cli.rs Show resolved Hide resolved
arrow-flight/tests/flight_sql_client_cli.rs Outdated Show resolved Hide resolved
arrow-flight/tests/flight_sql_client_cli.rs
Err(Status::unimplemented("do_handshake not implemented"))
}

async fn do_get_fallback(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome -- thank you @crepererum

avantgardnerio
avantgardnerio approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, ty @crepererum

@crepererum @alamb
refactor: improve test code
7e2376f 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb alamb merged commit fb35d26 into apache:master Mar 9, 2023
@alamb
Copy link
Contributor

alamb commented Mar 9, 2023

Thanks again @crepererum

@ursabot
Copy link

ursabot commented Mar 9, 2023

Benchmark runs are scheduled for baseline = fb1dcc6 and contender = fb35d26. fb35d26 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FlightSQL CLI client: simple test
4 participants
@crepererum @alamb @ursabot @avantgardnerio