Doctests for FixedSizeBinaryArray #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
// @alamb |
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 162 162
Lines 44199 44214 +15
=======================================
+ Hits 36509 36525 +16
+ Misses 7690 7689 -1
Continue to review full report at Codecov.
|
Dandandan
approved these changes
May 29, 2021
|
The windows failure is unrelated to this PR |
alamb
added a commit
that referenced
this pull request
Jun 4, 2021
* Doctests for BooleanArray. * Update arrow/src/array/array_boolean.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Doctests for FixedSizeBinaryArray. * Fix formatting. Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
that referenced
this pull request
Jun 5, 2021
* Doctests for BooleanArray. * Update arrow/src/array/array_boolean.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Doctests for FixedSizeBinaryArray. * Fix formatting. Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Navin <navin@cogent.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #301
Rationale for this change
Additional test coverage and documentation
Are there any user-facing changes?
No