Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register Flight.proto with cargo if it exists #351

Merged
merged 1 commit into from
May 26, 2021

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #350.

Experimentation suggests if you "register" a file that doesn't exist with cargo:rerun-if-changed, it will always re-compile the crate. My hope is that this will resolve #350

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. What do you think @nevi-me ?

@codecov-commenter
Copy link

Codecov Report

Merging #351 (d5777ce) into master (488f826) will not change coverage.
The diff coverage is n/a.

❗ Current head d5777ce differs from pull request most recent head a729b6e. Consider uploading reports for the commit a729b6e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files         162      162           
  Lines       44063    44063           
=======================================
  Hits        36379    36379           
  Misses       7684     7684           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f826...a729b6e. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented May 25, 2021

The MIRI failure is unrelated to this PR: #345

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense, thanks @tustvold @alamb

@nevi-me nevi-me merged commit 7753f41 into apache:master May 26, 2021
nevi-me pushed a commit that referenced this pull request May 27, 2021
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow-flight only register rerun-if-changed if file exists
4 participants