Fix comparison of dictionaries with different values arrays (#332) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 20, 2021
| @@ -94,7 +94,7 @@ where | |||
| let right_keys = right.keys_array(); | |||
|
|
|||
| let left_values = StringArray::from(left.values().data().clone()); | |||
| let right_values = StringArray::from(left.values().data().clone()); | |||
| let right_values = StringArray::from(right.values().data().clone()); | |||
There was a problem hiding this comment.
Here's the copypasta
alamb
approved these changes
May 20, 2021
8 tasks
alamb
pushed a commit
that referenced
this pull request
May 25, 2021
alamb
added a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #332.
Rationale for this change
Currently when comparing dictionaries it will use the values array from the left operand with the keys of the right operand. Not only could this lead to invalid indexes, but it will commonly lead to incorrect results
Are there any user-facing changes?
Comparison should now behave as the user would expect