Add ported Rust release verification script #331
Conversation
|
Thank you very much @wesm -- I will give this a spin shortly (and add a reference to it in the "how to make a release docs") |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 82.52% 82.53%
=======================================
Files 162 162
Lines 44021 44043 +22
=======================================
+ Hits 36329 36349 +20
- Misses 7692 7694 +2
Continue to review full report at Codecov.
|
| RUSTFLAGS="-D warnings" cargo build | ||
| cargo test |
There was a problem hiding this comment.
This only builds and tests with default features. There are some Cargo subcommands that can help to build all feature combinations.
There was a problem hiding this comment.
perhaps we can some inspiration from the CI checks: https://github.com/apache/arrow-rs/blob/master/.github/workflows/rust.yml#L114
(perhaps as part of a follow on PR)
There was a problem hiding this comment.
I think that this depends on the goal: is the goal to run all tests in different machines and configurations, to maximize architecture coverage? Or is more like a smoke test just to test that the basics work?
If the latter, then I think it is good as is. If the latter, then we need to basically reproduce all the tests in the CI here.
The source of truth about whether patches are ready to merge is the CI; IMO it should also be the source of truth about whether the code is releasable. In this context, I see this as a smoke test.
If we want to make some assertions over whether the code passes in architecture X, imo such assertion should be made on the CI, so that we do not rely on individual persons owning such an architecture for this.
There was a problem hiding this comment.
I ran it locally and it works as advertised. Thanks a lot, @wesm for this.
I left 2 comments.
| # raises on any formatting errors | ||
| rustup component add rustfmt --toolchain stable | ||
| cargo +stable fmt --all -- --check | ||
| rustup default stable |
There was a problem hiding this comment.
This should not be needed; by default rust installs the stable channel.
| */Cargo.toml | ||
|
|
||
| # raises on any warnings | ||
| RUSTFLAGS="-D warnings" cargo build |
There was a problem hiding this comment.
imo if -D warnings it is not on the CI, it should not be here, as it can otherwise cause the build to fail here but not on the CI.
(I am fine adding it to the CI, just pointing out that imo the release check should be as close as possible to the CI, so that we do not get surprises after cutting an RC). So far our ground truth is the CI, not a check on the RC.
|
Please feel free to push the changes you want to make and merge this. I presume it can be an evolving thing to make the RC verification both streamlined and comprehensive |
|
I was not sure I could push directly to your repo, so created a PR to it. |
|
This PR looks good |
There was a problem hiding this comment.
I ran this locally, and it worked great. Thanks again @wesm and @jorgecarleitao
👍
Closes #327
This adapts the RC verification script from apache/arrow to just work for Rust. I used it to verify 4.1.0 RC2. It checks the GPG signature and runs the test suite.