Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable getrandom object_store #3278

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Dec 5, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Added in #2896

The docs advise against this

Also, libraries should not introduce their own js features just to enable getrandom’s js feature.

Also according to the docs

This feature has no effect on targets other than wasm32-unknown-unknown.

So it isn't actively harmful, but it doesn't appear to be necessary so should just be removed

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Dec 5, 2022
@tustvold tustvold requested a review from alamb December 5, 2022 22:27
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI check for building object_store against wasm https://github.com/apache/arrow-rs/actions/runs/3624523463/jobs/6111594018 appears to be working just fine

So is the idea that the crate that needs getrandom support can enable the features?

maybe @jondo2010 can offer any additional rationale for why they added getrandom?

@tustvold tustvold merged commit 99ced48 into apache:master Dec 6, 2022
@ursabot
Copy link

ursabot commented Dec 6, 2022

Benchmark runs are scheduled for baseline = 7c75a66 and contender = 99ced48. 99ced48 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants