fix(object_store,aws,gcp): multipart upload enforce size limit of 5 MiB not 5MB #3234
Conversation
wjones127
changed the title
wjones127
changed the title
object_store/src/lib.rs
Outdated
| @@ -769,7 +769,7 @@ mod tests { | |||
| assert_eq!(bytes_expected, bytes_written); | |||
|
|
|||
| // Can overwrite some storage | |||
| let data = get_vec_of_bytes(5_000, 5); | |||
| let data = get_vec_of_bytes(1_123_000, 5); | |||
There was a problem hiding this comment.
This test doesn't seem to "work" in that it passes even when it should fail. Investigating
There was a problem hiding this comment.
Thanks for checking that; I lowered it after I reproduced earlier but didn't retest.
tustvold
changed the title
|
Benchmark runs are scheduled for baseline = f133621 and contender = 8f5fd9a. 8f5fd9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3233.
Rationale for this change
Bumping up the size of the test data as well, so it's easier to catch this. However, I think the localstack emulator might not enforce this limit, which is why we didn't catch this earlier.
What changes are included in this PR?
Are there any user-facing changes?